Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hackermode theme deps #2368

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

BeksOmega
Copy link
Contributor

Updates the hackermode deps to depend on plugins that depend on v11. Other plugins get automatically updated, but this one doesn't because it's private. This is blocking updating the ghpages for samples.

@BeksOmega BeksOmega requested a review from a team as a code owner May 21, 2024 18:08
@BeksOmega BeksOmega requested review from NeilFraser and removed request for a team May 21, 2024 18:08
@BeksOmega BeksOmega merged commit e0b13a9 into google:master May 21, 2024
9 checks passed
@RoachLin
Copy link

RoachLin commented Jun 5, 2024

Is hackermode theme a private theme?
I tried to install it following the guide (https://github.com/google/blockly-samples/tree/master/plugins/theme-hackermode#npm),
but it failed, and I can't find it on npm (https://www.npmjs.com/search?q=keywords:blockly-theme)

@BeksOmega
Copy link
Contributor Author

Hello! The hackermode theme is indeed private because you can't change the text color in a generalized way from the theme, and the hackermode theme kind of pretty dependent on that :/ However, feel free to reference the source code to build your own!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants